Replace IP by DNS Name

Let me try to do a PropertySource as we never know what will happen :)/emoticons/smile@2x.png 2x" title=":)" width="20">

I created the PropertySource "_Replace_IP_Address_by_DNSName"

Testing now...

Thanks,

Dom

Hey, looking good. You should see the ip2dns.result property on the device now. 

It looks like you're trying to call the Send-Request function without actually having that function defined. It might be as simple as copying the Send-Request function from the script you were given. If that function is written properly, it should work. 

1 minute ago, Dominique said:

BTW when doing "test script" in the PropertySource does it write the machine used during the test?

Any properties written using "Write-Host" will not be saved to the device, but the patch operation would be attempted. However, you're missing the Send-Request function definition, so nothing's being done.

9 minutes ago, Stuart Weenig said:

Hey, looking good. You should see the ip2dns.result property on the device now. 

It looks like you're trying to call the Send-Request function without actually having that function defined. It might be as simple as copying the Send-Request function from the script you were given. If that function is written properly, it should work. 

Yes ip2dns.result is on the device.

$accessId = '##IP2DNS.ACCESSID##'
$accessKey = '##IP2DNS.KEY##'
$company = 'uclahealth'

# Functionize the reusable code that builds and executes the query
function Send-Request() {
    Param(
        [Parameter(position = 0, Mandatory = $true)]
        [string]$path,
        [Parameter(position = 1, Mandatory = $false)]
        [string]$httpVerb = 'GET',
        [Parameter(position = 2, Mandatory = $false)]
        [string]$queryParams,
        [Parameter(position = 3, Mandatory = $false)]
        [PSObject]$data
    )
    # Use TLS 1.2
    [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
    <# Construct URL #>
    $url = "https://$company.logicmonitor.com/santaba/rest$path$queryParams"
    <# Get current time in milliseconds #>
    $epoch = [Math]::Round((New-TimeSpan -start (Get-Date -Date "1/1/1970") -end (Get-Date).ToUniversalTime()).TotalMilliseconds)
    <# Concatenate Request Details #>
    $requestVars = $httpVerb + $epoch + $data + $path
    <# Construct Signature #>
    $hmac = New-Object System.Security.Cryptography.HMACSHA256
    $hmac.Key = [Text.Encoding]::UTF8.GetBytes($accessKey)
    $signatureBytes = $hmac.ComputeHash([Text.Encoding]::UTF8.GetBytes($requestVars))
    $signatureHex = [System.BitConverter]::ToString($signatureBytes) -replace '-'
    $signature = [System.Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes($signatureHex.ToLower()))
    <# Construct Headers #>
    $auth = 'LMv1 ' + $accessId + ':' + $signature + ':' + $epoch
    $headers = New-Object "System.Collections.Generic.Dictionary[[String],[String]]"
    $headers.Add("Authorization", $auth)
    $headers.Add("Content-Type", 'application/json')
    $headers.Add("X-version", '2')
    <# Make request & retry if failed due to rate limiting #>
    $Stoploop = $false
    do {
        try {
            <# Make Request #>
            $response = Invoke-RestMethod -Uri $url -Method $httpVerb -Body $data -Header $headers
            $Stoploop = $true
        } catch {
            switch ($_) {
                { $_.Exception.Response.StatusCode.value__ -eq 429 } {
                    Write-Host "Request exceeded rate limit, retrying in 60 seconds..."
                    Start-Sleep -Seconds 60
                    $response = Invoke-RestMethod -Uri $url -Method $httpVerb -Body $data -Header $headers
                }
                { $_.Exception.Response.StatusCode.value__ } {
                    Write-Host "Request failed, not as a result of rate limiting"
                    # Dig into the exception to get the Response details.
                    # Note that value__ is not a typo.
                    Write-Host "StatusCode:" $_.Exception.Response.StatusCode.value__
                    Write-Host "StatusDescription:" $_.Exception.Response.StatusCode
                    $_.ErrorDetails.Message -match '{"errorMessage":"([\d\S\s]+)","errorCode":(\d+),'
                    Write-Host "LM ErrorMessage" $matches[1]
                    Write-Host "LM ErrorCode" $matches[2]
                    $response = $null
                    $Stoploop = $true
                }
                default {
                    Write-Host "An Unknown Exception occurred:"
                    Write-Host $_ | Format-List -Force
                $response = $null
                $Stoploop = $true
            }
        }
    }
} While ($Stoploop -eq $false)
Return $response
}
##
## Script 
##
$deviceID = '##SYSTEM.DEVICEID##'

$currentName = '##SYSTEM.HOSTNAME##'
$currentDisplayName = '##SYSTEM.DISPLAYNAME##'

if ($currentName -ne $currentDisplayName) {
  # do a patch here to update the Name
  # you need to patch to 
  # 'https://uclahealth.logicmonitor.com/santaba/rest/device/devices/$($deviceID)?patchFields=displayName'
  # and the payload of your HTTP request needs to have something like the following JSON:
  # {"displayName":"$currentName"}
  #Request Info
        $httpVerb = 'PATCH'
        $resourcePath = '/device/devices/128'
        $queryParams = '?patchFields=displayName'
        $data = '{"displayName":"$currentName"}'
  Send-Request $resourcePath $httpVerb $queryParams $data
  Write-Host "ip2dns.result=Changed IP $($currentName) to DNS $($currentDisplayName)"
} else {
  Write-Host "ip2dns.result=Did not change IP to DNS"
}

Added the Function SendRequest but getting an Error ...

Yeah, you have some Write-Host statements in the function that are being output along with the final output. The only output should be the actual property with its value.

Instead of doing the Write-Host statements, you could maintain an "output" variable with all the debug messaging and then at the end output that in your final if/else statement.

I commented all Write-Host statements in the function... 

#########################      API Function Script      #########################
#------------------------------------------------------------------------------------------------------------
# Prerequisites:
#
#Requires -Version 3
#------------------------------------------------------------------------------------------------------------
# Initialize Variables
<# account info #>
$accessId = '##IP2DNS.ACCESSID##'
$accessKey = '##IP2DNS.KEY##'
$company = 'uclahealth'

# Functionize the reusable code that builds and executes the query
function Send-Request() {
    Param(
        [Parameter(position = 0, Mandatory = $true)]
        [string]$path,
        [Parameter(position = 1, Mandatory = $false)]
        [string]$httpVerb = 'GET',
        [Parameter(position = 2, Mandatory = $false)]
        [string]$queryParams,
        [Parameter(position = 3, Mandatory = $false)]
        [PSObject]$data
    )
    # Use TLS 1.2
    [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
    <# Construct URL #>
    $url = "https://$company.logicmonitor.com/santaba/rest$path$queryParams"
    <# Get current time in milliseconds #>
    $epoch = [Math]::Round((New-TimeSpan -start (Get-Date -Date "1/1/1970") -end (Get-Date).ToUniversalTime()).TotalMilliseconds)
    <# Concatenate Request Details #>
    $requestVars = $httpVerb + $epoch + $data + $path
    <# Construct Signature #>
    $hmac = New-Object System.Security.Cryptography.HMACSHA256
    $hmac.Key = [Text.Encoding]::UTF8.GetBytes($accessKey)
    $signatureBytes = $hmac.ComputeHash([Text.Encoding]::UTF8.GetBytes($requestVars))
    $signatureHex = [System.BitConverter]::ToString($signatureBytes) -replace '-'
    $signature = [System.Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes($signatureHex.ToLower()))
    <# Construct Headers #>
    $auth = 'LMv1 ' + $accessId + ':' + $signature + ':' + $epoch
    $headers = New-Object "System.Collections.Generic.Dictionary[[String],[String]]"
    $headers.Add("Authorization", $auth)
    $headers.Add("Content-Type", 'application/json')
    $headers.Add("X-version", '2')
    <# Make request & retry if failed due to rate limiting #>
    $Stoploop = $false
    do {
        try {
            <# Make Request #>
            $response = Invoke-RestMethod -Uri $url -Method $httpVerb -Body $data -Header $headers
            $Stoploop = $true
        } catch {
            switch ($_) {
                { $_.Exception.Response.StatusCode.value__ -eq 429 } {
#                    Write-Host "Request exceeded rate limit, retrying in 60 seconds..."
                    Start-Sleep -Seconds 60
                    $response = Invoke-RestMethod -Uri $url -Method $httpVerb -Body $data -Header $headers
                }
                { $_.Exception.Response.StatusCode.value__ } {
#                    Write-Host "Request failed, not as a result of rate limiting"
                    # Dig into the exception to get the Response details.
                    # Note that value__ is not a typo.
#                    Write-Host "StatusCode:" $_.Exception.Response.StatusCode.value__
#                    Write-Host "StatusDescription:" $_.Exception.Response.StatusCode
#                    $_.ErrorDetails.Message -match '{"errorMessage":"([\d\S\s]+)","errorCode":(\d+),'
#                    Write-Host "LM ErrorMessage" $matches[1]
#                    Write-Host "LM ErrorCode" $matches[2]
                    $response = $null
                    $Stoploop = $true
                }
                default {
#                    Write-Host "An Unknown Exception occurred:"
#                    Write-Host $_ | Format-List -Force
                $response = $null
                $Stoploop = $true
            }
        }
    }
} While ($Stoploop -eq $false)
Return $response
}
##
#------------------------------------------------------------------------------------------------------------
#  Starting Script 
#------------------------------------------------------------------------------------------------------------
##
$deviceID = '##SYSTEM.DEVICEID##'

$currentName = '##SYSTEM.HOSTNAME##'
$currentDisplayName = '##SYSTEM.DISPLAYNAME##'

if ($currentName -ne $currentDisplayName) {
  # do a patch here to update the Name
  # you need to patch to 
  # 'https://uclahealth.logicmonitor.com/santaba/rest/device/devices/$($deviceID)?patchFields=displayName'
  # and the payload of your HTTP request needs to have something like the following JSON:
  # {"displayName":"$currentName"}
  #Request Info
        $httpVerb = 'PATCH'
        $resourcePath = '/device/devices/128'
        $queryParams = '?patchFields=displayName'
        $data = '{"displayName":"$currentName"}'
  Send-Request $resourcePath $httpVerb $queryParams $data
  Write-Host "ip2dns.result=Changed IP $($currentName) to DNS $($currentDisplayName)"
} else {
  Write-Host "ip2dns.result=Did not change IP to DNS"
}

but still no update !!

Thanks,
Dom