Is there a way to set custom property values from your groovy script in your datasource?

I don’t think hostProps.get() does anything in production. Even if it did, you’d want instanceProps.set(), but AFAIK that doesn’t do anything either. There are two ways to write a property to an instance: 1) discovery and 2) API (or you could hack the collector).

Discovery:

If you want, your discovery script can set/update instance level properties every time it runs. The most frequent you can force this to run is every 15 minutes, so that may not work. However, if you want to go that route, you’d need to include something in the 5th term of each discovery script output line. Each output line has 5 terms, separated by double hashtags. The last is a url parameter style list of properties. So, if your discovery right now is outputting:

id##name##description

You’d need it to output:

id##name##description####prop1=value1&prop2=value2

Where prop1 and prop2 are the names of the properties you want to add and value1 and value2 are the values of those properties, respectively. More here.

API

If you need it more often, you would need a function in your collection script to call the API to patch the instance’s properties. The UI does this with a PUT on the instance, so you’d have to have the entire definition of the instance in json format so you could update it. There is a PATCH option, which might fit your use case better. All of this requires now that your DS have access to API credentials as properties. All of that is doable, but I haven’t done it before. In this case, you’re basically replicating what instanceProps.set() would do.

Put in another feedback ticket for instanceProps.set() (and hostProps.set()).
 

Also, this is exactly what LM Actions should do, if it ever becomes more than an idea.

Thanks again for pointing me at the API methods.  I’m messing around in postman first to make sure i can do all the things I want.  I’m still struggling a bit to find the correct datasource though.  

I’m at the right device using 

get device/devices/{id}/datasources

From there i have a list of all the datasources but i dont see the one that i need.

Microsoft_SQLServer_GlobalPerformance.  I assume I’m misinterpreting how this should work again, but unsure.  

**edit** did a little bit of of digging and was able to find the datasourceid even though it wasn’t in that list i got from the get method

**edit 2**   I succesfully patched the property i wanted to patch through postman.  now to use it in logic mon

Alright, I know you’ve already got yours working but I’ve been meaning to simplifying this into a single function for years and never got around to it. Well, now I have. Hopefully the documentation is sufficient. I’m not sure it’ll fix the issue you’re having with the devices on the lab collectors, but I’d be interested to know how it goes for you.

Well now i feel dumb.  it was simple as dropping the ‘’

Don’t beat yourself up. Your mind was obviously working on the more difficult problems that you’ve still to surmount.

Good thinking.  In the mean time I’m gonna take a step back and figure out getting a proper auth signature in my script so i dont need to just copy and paste for testing.  It will need to be done regardless so while I wait for a response from them ill tackle this

I got it.  I’m using Apache for what it’s worth to putt the request.  When you make a request with parameters using it you have to use 

import org.apache.http.client.utils.URIBuilder

Then Build the URI like so

URI uri = new URIBuilder(httpGet.getURI())

      .addParameter("fields", "id")

      .addParameter("filter", "dataSourceName:Microsoft_SQLServer_GlobalPerformance")

      .build();

    httpGet.setURI(uri);

I can post the whole code if you want to see.

Ah, Groovy error messages. So helpful.

FYI, this:

datapull = new JsonSlurper().parseText(responseBody.toString());

datapull =   datapull.data.items.id.value.toString()

datapull = datapull.replace("[","")

datasouceid = datapull.replace("]","")

Can be just this:

datapull = new JsonSlurper().parseText(responseBody.toString())[0]

Are you closing something that doesn’t exist?

httpdsid.close()
httpinstanceid.close()

Where are these objects defined?

CloseableHttpClient httpinstanceid = HttpClients.createDefault();

they are defined here right below the http get comments

and thanks for the shortening!