Does the API work for updating a Collector's customProperties? (V1)

Question

I have some code that snags the custom properties from a collector (/setting/collectors) and then I'm updating or adding one, and then I use /setting/collectors with the collector ID to make an update.
	And my code works perfectly if I update the description and put the description as the patchFields. I can update my description to "MEH" or whatever.

But as soon as I try to set the customProperties, nothing happens. The data is just like it needs to be. I even get a response of 200.

So I can update description but not customProperties. I wonder if I'm doing it right, maybe you cant update them in bulk (total replace)?

Any thoughts? Code fragment below.

&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if c_update_required == True:
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; print ("Update REQUIRED")
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; patch_data = '{\'customProperties\': ' + str(new_collector_properties) + '}'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; #patch_data = '{"description":"' + 'MEH' + '"}'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; http_verb ='PATCH'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; print (patch_data)
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; resource_path = '/setting/collectors/'+collector_id
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; query_params ='?patchFields=customProperties'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; #query_params ='?patchFields=description'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; url = 'https://'+ Company +'.logicmonitor.com/santaba/rest' + resource_path + query_params
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; epoch = str(int(time.time() * 1000))
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; requestVars = http_verb + epoch + patch_data + resource_path
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; hmac1 = hmac.new(AccessKey.encode(),msg=requestVars.encode(),digestmod=hashlib.sha256).hexdigest()
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; signature = base64.b64encode(hmac1.encode())
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; auth = 'LMv1 ' + AccessId + ':' + signature.decode() + ':' + epoch
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; headers = {'Content-Type':'application/json','Authorization':auth}
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp;
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; patch_response = lm_session.patch(url, data=patch_data, headers=headers)

&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if patch_response.ok:
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; print("Success")
	&nbsp;

Oh and below you can see the customProperties I get back when snagging it, and what I have it set to when I try to set it. I'm sure its right. BUT I am completely stumped. Success 200. No change.

&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; GET DATA:&nbsp; &nbsp; customProperties': [{'name': 'bar', 'value': 'Melvin NoName'}, {'name': 'foo', 'value': '123'}]
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; PATCH DATA: 'customProperties': [{'name': 'bar', 'value': 'Melvin NoName'}, {'name': 'foo', 'value': '123'}, {'name': 'mynew.clientID', 'value': '1037524379'}]
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp;
	Any ideas? Description works, customProperties does nothing, but both give status 200.

&nbsp;

lewis_beard · Answer

Just in case someone finds this later, it seems that v1 just didnt do it. I switched to v3 using the header, and converted my patch data to json compatible (swapping single quotes for doubles) and it worked fine (I had tried the json format on the single quote version in my OP under v1 and it didnt work).

Here is the final code fragment, in case anyone is interested. I changed 3 things, more or less: 1) resource path changed to v3 style, 2) headers have v3 info in them, 3) I converted the re-built collector properties to json style with json.dumps.

&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; #update the COLLECTOR CONTEXT if required
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if c_update_required == True:
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; #build request (API v3)
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; patch_data = '{"customProperties": ' + json.dumps(new_collector_properties) + '}'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; http_verb ='PATCH'
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; resource_path = '/setting/collector/collectors/'+collector_id
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; query_params =''
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; url = 'https://'+ Company +'.logicmonitor.com/santaba/rest' + resource_path + query_params
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; epoch = str(int(time.time() * 1000))
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; requestVars = http_verb + epoch + patch_data + resource_path
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; hmac1 = hmac.new(AccessKey.encode(),msg=requestVars.encode(),digestmod=hashlib.sha256).hexdigest()
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; signature = base64.b64encode(hmac1.encode())
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; auth = 'LMv1 ' + AccessId + ':' + signature.decode() + ':' + epoch
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; headers = {'Content-Type':'application/json','Authorization':auth,'X-Version': '3'}
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp;
	&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; patch_response = lm_session.patch(url, data=patch_data, headers=headers)

&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if patch_response.ok:
	&nbsp;

(etc)

anonymous · Answer

Yeah, def don't build on API v1. It's going away "soon".

Forum Discussion

Does the API work for updating a Collector's customProperties? (V1)

Related Content

Bug early release Collector Update V34.500

LogicModule Updates in UIV4

Feature request - Use CustomProperty instead of ##RESOURCENAME## or ##RESOURCEGROUP##

Collectors: Open Telemetry vs. LM Collector

Plugin update for LogicMonitor to ServiceNow Integration

Recent Discussions

Does anyone monitor their iDracs with LM? Tons of duplicate alerts

How do you monitor Running Services on Linux boxes?

Event Sources SNMP and Windows collectors?

Can anyone help modify this Datasource to be able to use any port?

⚠️COMMUNITY OUTAGE⚠️ Posts and replies fail only titles visible